Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add real size to backing image #3104

Merged
merged 1 commit into from
Oct 7, 2024
Merged

feat: add real size to backing image #3104

merged 1 commit into from
Oct 7, 2024

Conversation

ChanYiLin
Copy link
Contributor

ref: longhorn/longhorn#8757

  • store realsize of backingimage in status
  • add the realsize to storageScheduled in diskStatus
  • add new field scheduledBackingImage in diskStatus

@ChanYiLin ChanYiLin self-assigned this Aug 26, 2024
@ChanYiLin ChanYiLin force-pushed the LH8757_record_backing_image_real_size branch 2 times, most recently from d282af0 to c22ca97 Compare August 26, 2024 13:42
@mergify Mergify
Copy link

mergify bot commented Aug 26, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin
Copy link
Contributor Author

Pending

Wait for

@ChanYiLin ChanYiLin mentioned this pull request Sep 20, 2024
Closed
@ChanYiLin ChanYiLin force-pushed the LH8757_record_backing_image_real_size branch 3 times, most recently from 1a5db6c to a82928a Compare September 24, 2024 06:41
@ChanYiLin ChanYiLin marked this pull request as ready for review September 24, 2024 06:45
@ChanYiLin
Copy link
Contributor Author

Hi @derekbit @shuo-wu
This PR is ready for review, thanks!

@ChanYiLin ChanYiLin force-pushed the LH8757_record_backing_image_real_size branch 3 times, most recently from 9c0468a to 6a00d8f Compare September 24, 2024 08:48
shuo-wu
shuo-wu previously approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@shuo-wu shuo-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM

controller/backing_image_controller.go Show resolved Hide resolved
controller/backing_image_controller.go Outdated Show resolved Hide resolved
derekbit
derekbit reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM. After resolving the comments, we can merge the PR.

controller/backing_image_controller.go Outdated Show resolved Hide resolved
@derekbit derekbit force-pushed the LH8757_record_backing_image_real_size branch from 6a00d8f to 7f7861b Compare September 27, 2024 13:23
@mergify Mergify
Copy link

mergify bot commented Oct 7, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin ChanYiLin force-pushed the LH8757_record_backing_image_real_size branch from 7f7861b to 4a3153a Compare October 7, 2024 07:18
@ChanYiLin
feat: add real size to backing image
90f9837 
ref: longhorn/longhonr 8757

Signed-off-by: Jack Lin <jack.lin@suse.com>
@ChanYiLin ChanYiLin force-pushed the LH8757_record_backing_image_real_size branch from 4a3153a to 90f9837 Compare October 7, 2024 07:21
@shuo-wu shuo-wu merged commit 5250f5a into longhorn:master Oct 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuo-wu shuo-wu shuo-wu approved these changes

@derekbit derekbit Awaiting requested review from derekbit

Assignees

@ChanYiLin ChanYiLin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChanYiLin @derekbit @shuo-wu